Skip to content

fix(explorer): keep contract tab on aggregate failure#909

Closed
decofe wants to merge 1 commit intomainfrom
fix/explorer-contract-tab-devnet
Closed

fix(explorer): keep contract tab on aggregate failure#909
decofe wants to merge 1 commit intomainfrom
fix/explorer-contract-tab-devnet

Conversation

@decofe
Copy link
Copy Markdown
Member

@decofe decofe commented May 1, 2026

Keeps address metadata usable when aggregate index queries fail, so contract pages still render the Contract tab based on bytecode alone.

This refactors the route so contract detection is derived up front from eth_getCode and is no longer coupled to TIDX-backed metadata. It also fixes the metadata fallback to return the active chain id instead of 0, and adds a regression test covering both cases.

Verification:

  • corepack pnpm exec vitest run --config vitest.node.config.ts test/address-metadata.node.test.ts

Notes:

  • corepack pnpm check:types in apps/explorer still fails on pre-existing unrelated typing issues in the workspace.
  • There is still a separate underlying devnet preview issue where tx-count / aggregate TIDX queries return Status: 400 for chainId 31318; this PR prevents that backend failure from hiding the contract tab, but does not resolve the TIDX-side 400 itself.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

Bundle Size Report

Metric Size Δ Change
Total 4.6 MB +407.3 KB (+9.4%)
Gzip 1.3 MB +121.2 KB (+9.7%)
Brotli 1.2 MB +106.0 KB (+9.8%)
Chunk changes (>1KB)
Chunk Change
assets/chains.js (removed) -360.7 KB
assets/export-rate-limit.js (removed) -177.3 KB
assets/wagmi.config.js -29.5 KB
assets/AbiItem.js (removed) -27.1 KB
assets/env.js -9.6 KB
assets/validators.js (removed) -5.1 KB
assets/call.js +1.2 KB
assets/_address.js +1.4 KB
assets/parseAbiItem.js (new) +1.6 KB
assets/.js +1.7 KB
assets/known-event-totals.js (new) +2.0 KB
assets/tempo-queries.js +2.4 KB
assets/Addresses.js (new) +9.1 KB
assets/schemas.js +22.7 KB
assets/structs.js (new) +23.9 KB
assets/queries.js +26.4 KB
assets/Connectors.js (new) +55.5 KB
assets/token.js +56.1 KB
assets/manifest.js (new) +173.8 KB
assets/dist.js (new) +294.0 KB
...and 1 more

Compared against main branch (baseline from 4/27/2026, 4:02:54 PM)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

Cloudflare Deployments

App Environment Status Preview
explorer devnet [OK] Deployed View Preview
explorer mainnet [OK] Deployed View Preview
explorer testnet [OK] Deployed View Preview
fee-payer devnet [>>] Skipped No changes
fee-payer moderato [>>] Skipped No changes
fee-payer privy [>>] Skipped No changes
og - [>>] Skipped No changes
perf - [>>] Skipped No changes
tokenlist - [>>] Skipped No changes

@decofe
Copy link
Copy Markdown
Member Author

decofe commented May 1, 2026

Superseded by #907; moved the contract-tab hardening fix onto the existing preview branch.

@decofe decofe closed this May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant